Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pls add version on OS X #283

Closed
smartmanru opened this issue Nov 11, 2020 · 13 comments
Closed

Pls add version on OS X #283

smartmanru opened this issue Nov 11, 2020 · 13 comments
Labels
enhancement New feature or request

Comments

@smartmanru
Copy link

Pls add version for Mac os X and create bottle on homebrew

@mattrose
Copy link
Member

I'm actually running terminator on my macos desktop. I would like to polish it up considerably before putting it in homebrew though for a couple of reasons.

  1. A lot of different keybindings require an upstream patch for VTE that hasn't been accepted. I would have to fix up that patch considerably and add it to the vte3 homebrew package. See patch at https://gitlab.gnome.org/GNOME/vte/-/issues/249

  2. The integration with macos is, tbh, pretty crappy. Each window just has a name of "Python" and each terminator window spawns a new process. It's messy.

If you want to help out, I'd be glad to accept any pull requests. You can get it running on macos right now, it's just not quite ready for prime-time yet.

@caioquirino
Copy link

Hi @mattrose do you have a fork that you are working on it? I was also working on it and started creating a brew bottle for the latest version as well

@mattrose
Copy link
Member

mattrose commented Apr 7, 2021

Any work I do on terminator for OSX is merged into this repo, so you can get it here. I'd love to see the brew bottle when you're done with it.

@mattrose mattrose added the enhancement New feature or request label May 31, 2021
@mattrose
Copy link
Member

Opened Homebrew/homebrew-core#79647

This was actually easier than I thought. The vte3 patch is no longer necessary, they must have fixed this recently.

It is kind of a pain to use out of the box, because you need to open a terminal to start terminator. This was mainly to comply with homebrew requirements (Don't ship a .app bundle). What I've done personally is use Platypus to create an app from the terminator command line.

I might clean this up and put it on my personal github.

@caioquirino
Copy link

Hi @mattrose really nice work on it! I really wanted to help more, but I have replaced my macbook with a dell laptop :(
I hope it works well :) Cheers!

@carlocab
Copy link

You can now install this with (macOS) Homebrew. Try

brew update && brew install terminator

It should be available for Homebrew on Linux in the next day or so.

It is kind of a pain to use out of the box, because you need to open a terminal to start terminator. This was mainly to comply with homebrew requirements (Don't ship a .app bundle). What I've done personally is use Platypus to create an app from the terminator command line.

Out of interest: does your build actually support generating an app bundle? Or do you build it with pip/python and then use Platypus?

@mattrose
Copy link
Member

I build it with python then use Platypus for now. I'm still trying to wrap my head around the osx specific stuff. I think I need to generate an app bundle by hand and integrate with the GtkOSXApplication library. Anytime I've tried this on my mac I end up lost and confused. I use Macs on a daily basis, but this is my first time developing anything for the platform.

@mattrose
Copy link
Member

Interesting story. When Markus and I took over the project, I hadn't used a Linux desktop in years and was exclusively using MacOS. I was happily using iTerm2 on MacOS, but I knew there was a bunch of people who used terminator and it made me sad to see it die due to lack of interest, so I agreed to maintain it with Markus.
One of the first things I did was get terminator working on MacOS so I could hack on it without opening a VM, so in a way this is kind of a culmination of a year of effort.

When I was ready to go back to work, I found a job that required a linux desktop, so now I again have to use terminator on a daily basis.

@lhoguin
Copy link

lhoguin commented Jun 22, 2021

Being able to run terminator on macOS is very nice. Great work!

Integration is messy for sure. It's even worse with the program I'm using that replaces Alt+Tab with a less application-centric equivalent: the terminal windows do not even show up. But I can probably live with that.

Window resizing is super slow, but at the same time it's not something that is often needed.

I can use Alfred to start a new terminator window directly, which is great. But like when I start terminator from the macOS terminal, the window originally appears behind the current window.

I will try to work with it in the coming days. This is very much appreciated!

@mattrose
Copy link
Member

Wow, that was quick. I have a hacky workaround for the fact that terminator seems to start in the background (Applescript to bring it to the front) which I can put here when I get back to my mac. I haven't noticed window resizing being slow but I'll keep an eye on it. Thanks for checking this out. Any improvements you can make are extremely welcome. Mac programming is not my forte.

@carlocab
Copy link

@mattrose that's a nice story! Guess that time you spent working on terminator paid off in the end.

Anytime I've tried this on my mac I end up lost and confused. I use Macs on a daily basis, but this is my first time developing anything for the platform.

That's typical. The macOS user experience is great. The native developer experience, not so much.

@mattrose
Copy link
Member

mattrose commented Jul 5, 2021

As promised, here's the applescript to bring the terminator window to the front.

    tell application "System Events"
        tell process "Python"
                set frontmost to true
        end tell
    end tell

@mattrose mattrose closed this as completed Aug 6, 2021
@mattrose
Copy link
Member

mattrose commented Aug 6, 2021

closing this, any further enhancements can be opened separately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants