Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unwanted transparent pane separators #293

Closed
santisoler opened this issue Nov 18, 2020 · 14 comments
Closed

Unwanted transparent pane separators #293

santisoler opened this issue Nov 18, 2020 · 14 comments

Comments

@santisoler
Copy link

santisoler commented Nov 18, 2020

When opening more than one tab, the tab separators look transparent using Matcha Dark-Sea theme on Manjaro XFCE.

image

I don't know if this is caused by a bug on terminator or a problem with the theme itself (I don't have the problem using another theme, like Adwaita). If the problem is theme-related, is there a way to set the color of the separators on gtk.css?

For the record, I had to set the color of the terminal separators (when tiling), otherwise they also look transparent using the same theme:

/* Fix terminator separator color */
separator {
  background-color: #222b2e;
  min-height: 1px;
  min-width: 1px;
}
@mattrose
Copy link
Member

What version is this? I think I fixed this in a PR a month or so ago

@santisoler
Copy link
Author

Sorry for my shitty and uninformative issue 🤦‍♂️ .
I'm running 1.92, the one on Manjaro repos.

I'll build the latest release and notify if the problem is still present.
Thanks for the quick response.

@santisoler
Copy link
Author

I'm getting the same transparent borders on 2.0.1:

image

@pedroflor
Copy link
Contributor

pedroflor commented Nov 25, 2020

Here the same issue:
Terminator 2.0.1
Linux Mint 20

image

@deathtrip
Copy link

On Arch Linux I also have the same transparent separator between vertical panes, as in the above picture.
It started happening on 1.92 and the split got bigger in 2.0.1

@AcidRain123456
Copy link

AcidRain123456 commented Jan 13, 2021

I also have this issue. I upgraded 1.92 to 2.0.1 where the problem occurred (from repository) then downloaded and installed 2.10. Problem still there. I noted terminal separator size was "-1" which according to the documentation makes it default to the system theme. The separators where also quite big as in the picture from pedroflor above.

I set a size of 1 (which overwrites the system setting) and the size of the separate is no 1 pixel (what I want) but they are still transparent. I have spent few hours researching gtk.css /usr/share/themes/Mint-Y/gtk-3.0 nd /usr/share/terminator/gtk.css (which did not exist) and nothing I found helps.

I have thinking it is a theme issue with Linux Mint. I am running Linux Mint 20 Cinnamon, Cinnamon version 4.6.7 with the Mint-> theme. No idea really what I need to change to get rid of these awful transparent separators...

I want to set them white.

@mattrose mattrose changed the title Unwanted transparent tabs separators Unwanted transparent pane separators Jan 15, 2021
@mattrose
Copy link
Member

mattrose commented Jan 16, 2021

Whatever theme you're using is not setting the CSS property for the pane separator. you can set this yourself if you add or edit ~/.config/gtk-3.0/gtk.css and add the following:

separator {
background-color: rgb(255,255,255) /* set separator to white */
}

Or whatever colour you prefer. Ideally, your GTK theme should be setting this.

@santisoler
Copy link
Author

Thanks @mattrose for the comment.

As I showed before, that CSS solution (set the background-color for the separator) works only for the separators of tiled terminals, although it doesn't solve the original problem of this issue, which are the transparent borders of tabs.

Let me know if I haven't explained myself well or if I'm missing something here.

@mattrose
Copy link
Member

ah, there should be a CSS property that determines that. I'll see if I can dig that up for you.

@santisoler
Copy link
Author

ah, there should be a CSS property that determines that. I'll see if I can dig that up for you.

I though the same, but didn't know where to look for CSS properties of gtk (is there something as the browser inspector but for gtk applications?)

Thanks again for the help!

@mattrose
Copy link
Member

Indeed there is. https://wiki.gnome.org/Projects/GTK/Inspector. Basically, to start it, make sure you have the gtk development packages installed, and run GTK_DEBUG=interactive terminator and you should get a window inspired by browser inspectors. I found it a little confusing to use at first, but it's been invaluable to me for troubleshooting issues like this.

@santisoler
Copy link
Author

santisoler commented Jan 19, 2021

Wow! That's amazing! I was able to run GtkInspector (you're right that it's kind of confusing at first) and find the CSS code needed to remove the border of the tabs. The problem was with the border of notebook and notebook header.

So, if you want to remove the borders, you need to add the following to your gtk.css file, which is usually located in ~/.config/gtk-3.0/gtk.css:

notebook, notebook header {
  border: 0px;
}

Alternatively, you can change the color of the border through CSS.

notebook, notebook header {
  border-color: white;
}

Thanks again @mattrose for the guidelines! Now I think this issue is closed and solved.

@mattrose
Copy link
Member

Glad to have helped. That GTK inspector is a gem once you get used to it.

@d6bels
Copy link

d6bels commented Apr 18, 2023

Here the same issue: Terminator 2.0.1 Linux Mint 20

image

Hi, so I just updated to Mint 21.1 from 20.3 and this issue is back.
I tried to write the gtk.css with the separator but it does nothing.

Is there something else that can be done to fix this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants