Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separators is wider after upgrading to ubuntu 21.04 #445

Closed
nikolaik opened this issue Jun 3, 2021 · 5 comments
Closed

Separators is wider after upgrading to ubuntu 21.04 #445

nikolaik opened this issue Jun 3, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@nikolaik
Copy link

nikolaik commented Jun 3, 2021

When upgrading to Ubuntu 21.04 with terminator version 2.1.0 the separators are much wider than before.

After a bit of digging I found these two lines could be commented out to revert to the old appearance:

self.props.wide_handle = True

self.props.wide_handle = True

  • Is there another way of disabling the wide borders?
  • Is the default GTK theme in Ubuntu making the resize handlers too big or something like that?
@mattrose
Copy link
Member

mattrose commented Jun 3, 2021

My guess would be that the default GTK theme is making the resize handlers bigger. The problem is, is that if that property is not set to True, then you lose the ability to select the first character in a vertical pane with your mouse. (Makes no sense, I know, but ... GTK). Also, I think it causes the handles to be transparent. I'll play with this a bit.

@mattrose
Copy link
Member

mattrose commented Jun 3, 2021

I just checked it out and ... it's not abnormally chunky. Honestly I think it's fine but if somebody wants to have a go at some custom CSS for it, I wouldn't object.

@nikolaik
Copy link
Author

nikolaik commented Jun 4, 2021

I just checked it out and ... it's not abnormally chunky. Honestly I think it's fine but if somebody wants to have a go at some custom CSS for it, I wouldn't object.

chunky indeed! Do you have any pointers on how to find the relevant CSS selectors and where it should belong?

@mattrose
Copy link
Member

mattrose commented Jun 4, 2021

Off the top of my head, you can find the relevant CSS by using the GTK Inspector https://wiki.gnome.org/Projects/GTK/Inspector

Basically, you can use the GTK Debug interface to play with CSS properties.
GTK_DEBUG=interactive terminator

@mattrose mattrose added the enhancement New feature or request label Jun 4, 2021
@mattrose
Copy link
Member

mattrose commented Aug 6, 2021

So, I've decided not to fix this feature, as the lines you point out actually fix a bug where you cannot select the first character of a vertically-split pane.

@mattrose mattrose closed this as completed Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants