Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

None isn't a valid value of keybindings config anymore #548

Closed
Felixoid opened this issue Dec 7, 2021 · 1 comment · Fixed by #549
Closed

None isn't a valid value of keybindings config anymore #548

Felixoid opened this issue Dec 7, 2021 · 1 comment · Fixed by #549
Labels
bug Something isn't working

Comments

@Felixoid
Copy link

Felixoid commented Dec 7, 2021

Fill out as many of these fields as you can

Describe the bug
None value in [keybindings] settings breaks the ability to set the keys.

To Reproduce

  1. Set cycle_next = "" - and launch terminator, try to change the key binding for anything. It works as expected of shows a dialogue X already in use to trigger Y
  2. Set cycle_next = None, now it's broken. I have config from an ancient version 2 years ago, back there it was a valid value

Expected behavior
I'd like to have the config backward compatible.

Desktop (please complete the following information):

  • OS or Linux Distribution: Arch Linux
  • Version terminator 2.1.1-2
  • Display Technology: X11

Additional context

# logs for "" value
> terminator -u -g /tmp/term.config 

** (terminator:17429): WARNING **: 11:53:19.939: Binding '<Control><Alt>a' failed!
Unable to bind hide_window key, another instance/window has it.
<window.Window object at 0x7fe96198c540 (terminatorlib+window+Window at 0x55aeffa66280)> is not in registered window list
# logs for None value
> terminator -u -g /tmp/term.config   

** (terminator:17261): WARNING **: 11:52:54.237: Binding '<Control><Alt>a' failed!
Unable to bind hide_window key, another instance/window has it.
Traceback (most recent call last):
  File "/usr/lib/python3.9/site-packages/terminatorlib/prefseditor.py", line 1719, in on_cellrenderer_accel_edited
    parsed_conf_accel = Gtk.accelerator_parse(conf_accel)
TypeError: Argument 0 does not allow None as a value
@Vulcalien
Copy link
Member

Hi! Thanks for bringing this up.
I could reproduce the bug, it shouldn't be hard to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants