Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Tests for factory flow added #42

Merged
merged 2 commits into from
Sep 3, 2021
Merged

Chore: Tests for factory flow added #42

merged 2 commits into from
Sep 3, 2021

Conversation

cbrzn
Copy link
Collaborator

@cbrzn cbrzn commented Aug 31, 2021 •
edited

Changes proposed on this PR:

  • Added a new file which is called FactoryFriendly.spec.ts and two tests cases has been added:
    1. Make sure that the module is deployed through factory and have the expected params
    2. MasterCopy can not be initialized twice
  • Created test contract to import ModuleProxyFactory - Can not import it in the same file as Imports because the Mock contracts are 0.6 and it has a version compatibility with 0.8

closes #39

@cbrzn cbrzn requested a review from rmeissner August 31, 2021 17:54
@github-actions
Copy link
Contributor

CLA Assistant Lite All Contributors have signed the CLA.

@cbrzn cbrzn marked this pull request as draft August 31, 2021 18:04
@coveralls
Copy link

coveralls commented Sep 1, 2021 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling 7443889 on test/factory-flow into 65007e4 on main.

Base automatically changed from feat/initialize-module to main September 1, 2021 13:33
@cbrzn cbrzn marked this pull request as ready for review September 1, 2021 14:13
@auryn-macmillan auryn-macmillan merged commit 61d3dd0 into main Sep 3, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Sep 3, 2021
@auryn-macmillan auryn-macmillan deleted the test/factory-flow branch July 14, 2022 12:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rmeissner rmeissner rmeissner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add test for factory flow
4 participants
@cbrzn @coveralls @rmeissner @auryn-macmillan