Skip to content
This repository has been archived by the owner on Jan 15, 2021. It is now read-only.

Playwright integration #1595

Merged
merged 57 commits into from
Nov 23, 2020
Merged

Playwright integration #1595

merged 57 commits into from
Nov 23, 2020

Conversation

Velenir
Copy link
Contributor

@Velenir Velenir commented Nov 9, 2020

As an alternative to cypress integration testing
PROs of playwright:

  • Can be used with jest
  • Doesn't pollute global types namespace (Chai expect)
  • Properly awaits browser actions (cypress retries with a timeout)
  • Simpler setup without scroll hackarounds
  • Record actions capabilities (try yarn playwright:record)

CONs (can't speak to the specifics, not much experience with cypress):

  • Less of an all-included solution

@gnosis-info
Copy link

Travis automatic deployment:

@anxolin
Copy link
Contributor

anxolin commented Nov 9, 2020

How easy would be to do a web3 integration? I guess something like Uniswap has for cypress, I believe they just inject a global ethereum object in the window implementing Eip1193

One thing I might do different would be, I think they use Rinkeby for the tests. Maybe for us is good too, however might be too slow for testing in develop, also harder to do repeatable test.

Although in a purist Integration test, is not too good to use a mocked thing, we could consider using Ganache CLI TestRPC

what do you think?

Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe u can create one test:integration script to be used by travis. Even if it's just "npm run playwrite"

With #1630 we won't have that script anymore

@Velenir Velenir merged commit de03574 into develop Nov 23, 2020
@Velenir Velenir deleted the playwright_integration branch November 23, 2020 13:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants