Skip to content
This repository has been archived by the owner on Jan 15, 2021. It is now read-only.

TokenPairSelector storybook #1611

Merged
merged 10 commits into from
Nov 17, 2020
Merged

TokenPairSelector storybook #1611

merged 10 commits into from
Nov 17, 2020

Conversation

fairlighteth
Copy link
Contributor

  • Creating a Story for the TokenPair selector.

@gnosis-info
Copy link

Travis automatic deployment:

* Add global styles decorator

* Simplify stories, use decorator
@fairlighteth fairlighteth marked this pull request as ready for review November 12, 2020 14:39
Copy link
Contributor

@W3stside W3stside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine to me, noice

Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for a first iteration, we should continue building the atoms of the app

@@ -0,0 +1,54 @@
import styled from 'styled-components'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given the amount of markdown and CSS I wouldn't have split into two files, specially because I expect that we refactor this further creating a set of buttons and stories of buttons, so this Token Pair selector has minimal CSS/HTML

Co-authored-by: Velenir <Velenir@users.noreply.github.com>
@fairlighteth fairlighteth changed the base branch from layout-v2-orderform to develop November 17, 2020 12:57
@fairlighteth fairlighteth merged commit f2c4566 into develop Nov 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants