This repository has been archived by the owner on Jan 15, 2021. It is now read-only.
V2 Tabs - Separate PR addressing comments #1634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
W3stside
reviewed
Nov 20, 2020
W3stside
reviewed
Nov 20, 2020
W3stside
reviewed
Nov 20, 2020
W3stside
suggested changes
Nov 20, 2020
Support string/ReactNode for tab content. Co-authored-by: David <david.sato64@gmail.com>
W3stside
changed the title
|
@biocom make sure to check it before commiting recommendations: ERROR in /home/travis/build/gnosis/dex-react/src/components/common/Tabs/Tabs.tsx
ERROR in /home/travis/build/gnosis/dex-react/src/components/common/Tabs/Tabs.tsx(43,19):
TS2322: Type 'ReactNode' is not assignable to type 'string | undefined'.
Type 'null' is not assignable to type 'string | undefined'.you can apply the change locally and then run |
W3stside
reviewed
Nov 20, 2020
Velenir
approved these changes
Nov 20, 2020
W3stside
approved these changes
Nov 20, 2020
W3stside
added a commit
that referenced
this pull request
Nov 23, 2020
* TabItem knows too much 1. id is not needed here as it is passed in by the smart parent 2. isActive in Wrapper isnt needed as activeColor can indicate isActive * simplify TabContent & change activeColor to required * Tabs changes 1. simplified as no more need for id or isActive 2. destructure in props 3. remove implicit type form useState hook * V2 Tabs - Separate PR addressing comments (#1634) * Refactxor. * Refactxor. * Fix ts any. * Update src/components/OrderBuySell/index.tsx Support string/ReactNode for tab content. Co-authored-by: David <david.sato64@gmail.com> * Refactor tabs * Remove console.log references * Fix content check. Co-authored-by: David <david.sato64@gmail.com> * fix develop merge conflicts * TabItem as button (merge error fix) Co-authored-by: Michel <31534717+biocom@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V2 Tabs - Separate PR addressing comments
Addresses comments left in #1629 also waterfalls in