Some Wave/WebAim recommended fixes.

[fairlighteth]

No description provided.

[gnosis-info]

Travis automatic deployment:

• 🎩 Dapp: Testing web app
• 📚 Storybook: Component stories

[anxolin]

it helps with the review if you add some description and/or screenshot if the change is visual

[anxolin]

is this sth u intended to do in this PR and forgot, or sth we need to address in the future?
not sure if I understand

[fairlighteth]

Intended to be addressed in the future. As this would apply to a lot more items.

[anxolin]

Okay. Maybe here is not worth it. For bigger things, or things we don't want to forget, we add a task as an issue or in the backlog so we don't forget. Although now we are not attending so much issues of this gpv1 (so we might even overlook)

[Velenir]

Where are these fixes recommended? Did you run code through some validator?
If this is because of lat & aria attributes, I'm pretty sure we don't have them in a thousand places
If you want them in, that would be one big PR...

[fairlighteth]

Where are these fixes recommended? Did you run code through some validator?
If this is because of lat & aria attributes, I'm pretty sure we don't have them in a thousand places
If you want them in, that would be one big PR...

Have been using https://chrome.google.com/webstore/detail/wave-evaluation-tool/jbbplnpkjmmeebjpijfedlgcdilocofh which is the WAVE evaluation tool.

My approach is to just tackle things step by step, instead of doing one big PR. These are recommended changes only for improving accessibility.

[W3stside]

While I think this is good, I think we should postpone this for until we have fully implemented playwright integratino so that it can test any potential regressions from adding these.

Not saying I think these will break anything (they shouldnt) BUT if we start changing tons of files and we mess sth up that isn't caught from linter or else, we'll be in trouble

[fairlighteth]

While I think this is good, I think we should postpone this for until we have fully implemented playwright integratino so that it can test any potential regressions from adding these.

Not saying I think these will break anything (they shouldnt) BUT if we start changing tons of files and we mess sth up that isn't caught from linter or else, we'll be in trouble

Fair point. As you pointed out, adding tags for accessibility should be validated HTML by default. But in practice things can happen.