Skip to content
This repository has been archived by the owner on Apr 27, 2022. It is now read-only.

Access control mechanism for settle function #103

Closed
fedgiac opened this issue Oct 27, 2020 · 2 comments · Fixed by #148
Closed

Access control mechanism for settle function #103

fedgiac opened this issue Oct 27, 2020 · 2 comments · Fixed by #148
Assignees
Milestone

Comments

@fedgiac
Copy link
Contributor

fedgiac commented Oct 27, 2020

Define the role of "owner" of the contract, which is expected to appoint and dismiss solvers.
Define the role of "solver", who can call the settle function.

@nlordell nlordell added this to the MVP milestone Oct 27, 2020
@bh2smith
Copy link
Contributor

bh2smith commented Oct 27, 2020

Could implement a contract exposing a function canSolve(address) -> bool that the settlement contract can call into to determine is the solver is allowed. Sort of like a curated list. This could eventually be replaced with a staking and slashing mechanism

@bh2smith bh2smith self-assigned this Nov 9, 2020
@nlordell
Copy link
Contributor

@josojo and I have a brief discussion on Slack, this is how we imagined it:

We have a contract called SolverAllowList. This contract can have any owner and maybe even a proxy infrastrucutre. The dao is the owner and manages all solvers within this SolverAllowList contract.
The settlement contract has a modifier onlySolver and this modifier calls into the SolverAllowList
to check whether a solver is allowlisted.
In this case, the settlement contract does not have an owner at all.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants