Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send msg.sender along to fallback handler #246

Closed
rmeissner opened this issue Jan 18, 2021 · 1 comment · Fixed by #270 or #287
Closed

Send msg.sender along to fallback handler #246

rmeissner opened this issue Jan 18, 2021 · 1 comment · Fixed by #270 or #287

Comments

@rmeissner
Copy link
Member

Currently the fallback handler doesn't have any way to detect what contract triggered it.

A similar approach to what GSN is doing can be used (e.g. appending msg.sender to the data).

The fallback handler then can extract the msg.sender (e.g. https://github.com/OpenZeppelin/openzeppelin-contracts/blob/solc-0.8/contracts/GSN/GSNRecipient.sol#L217)

@rmeissner
Copy link
Member Author

We should add a notice that this functionality should only be relied on in the fallback habdler with contracts that are of version 1.3.0 or newer. It might make sense to add a check for this in the HandlerContext contract

@rmeissner rmeissner reopened this Mar 6, 2021
Saw-mon-and-Natalie pushed a commit to Saw-mon-and-Natalie/safe-contracts that referenced this issue Nov 1, 2023
Saw-mon-and-Natalie pushed a commit to Saw-mon-and-Natalie/safe-contracts that referenced this issue Nov 1, 2023
farreldarian pushed a commit to farreldarian/safe-contracts that referenced this issue Jan 14, 2024
…able

Make signTransaction method immutable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant