Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #149: Attempt to fix send/ transfer issue #150

Merged
merged 5 commits into from Dec 3, 2019
Merged

Closes #149: Attempt to fix send/ transfer issue #150

merged 5 commits into from Dec 3, 2019

Conversation

rmeissner
Copy link
Member

@rmeissner rmeissner commented Nov 22, 2019 •
edited

See #149

  • Only emit the event for incoming transactions in the mastercopy in case of an EOA transfer or if enough gas is available
    • Note: we do NOT emit an event in the Proxy to avoid changes in behavior in different Safe versions and let the master copy handle every call
  • Make constants private to minimize code (required to avoid issues with EIP-170)
  • Optimize getModules to avoid issues with EIP-170

@rmeissner rmeissner requested a review from Uxio0 November 22, 2019 22:02
@rmeissner rmeissner self-assigned this Nov 26, 2019
@rmeissner rmeissner marked this pull request as ready for review November 26, 2019 22:56
cag
cag approved these changes Nov 29, 2019
View reviewed changes
Copy link

@cag cag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving the fallback handler setting is not a blocker for me because of the necessity to consistently behave like execTeransaction btw

@rmeissner rmeissner merged commit d735abf into development Dec 3, 2019
@rmeissner rmeissner deleted the feature/issue_149 branch December 3, 2019 15:08
@rmeissner rmeissner added this to the contracts-safe-1.1.1 milestone Dec 9, 2019
farreldarian pushed a commit to farreldarian/safe-contracts that referenced this pull request Jan 14, 2024
@germartinez
Merge pull request safe-global#150 from gnosis/fix-gas
e0df3be 
Fix gas issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cag cag cag approved these changes

@Uxio0 Uxio0 Uxio0 approved these changes

@Georgi87 Georgi87 Awaiting requested review from Georgi87

Assignees

@rmeissner rmeissner

Labels
None yet
Projects
None yet
Milestone
contracts-safe-1.1.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rmeissner @cag @Uxio0