Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update multi send #156

Merged
merged 5 commits into from Dec 9, 2019
Merged

Update multi send #156

merged 5 commits into from Dec 9, 2019

Conversation

rmeissner
Copy link
Member

  • Enforce that the multi send contract can only be called via a delegate call

cag
cag approved these changes Dec 9, 2019
View reviewed changes
Copy link

@cag cag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, I actually anticipated that this would be used in the solution, but this is fine too.

@rmeissner
Copy link
Member Author

Yes adam mentioned that we could predict the address of the deployed MultiSend and check against that (would also safe some gas), but this one is a little easier to deploy, therefore I would go with this for know and update the lib at a later point

@rmeissner rmeissner merged commit 8443cfa into development Dec 9, 2019
@rmeissner rmeissner deleted the feature/update_multi_send branch December 9, 2019 19:48
@rmeissner rmeissner modified the milestone: contracts-safe-1.1.1 Dec 9, 2019
@tschubotz tschubotz mentioned this pull request Jul 27, 2020
Closed
@markya0616 markya0616 mentioned this pull request Mar 2, 2021
Closed
farreldarian pushed a commit to farreldarian/safe-contracts that referenced this pull request Jan 14, 2024
@germartinez
Merge pull request safe-global#156 from protofire/main
caae096 
Update safe-deployments to v1.8.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cag cag cag approved these changes

@Georgi87 Georgi87 Awaiting requested review from Georgi87

@Uxio0 Uxio0 Awaiting requested review from Uxio0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
contracts-safe-1.1.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rmeissner @cag