Closes #229: Safe can be added as owner of itself #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uxio0
approved these changes
Feb 23, 2021
Uxio0
pushed a commit
that referenced
this pull request
May 6, 2021
Saw-mon-and-Natalie
pushed a commit
to Saw-mon-and-Natalie/safe-contracts
that referenced
this pull request
Nov 1, 2023
fdarian
pushed a commit
to fdarian/safe-contracts
that referenced
this pull request
Jan 14, 2024
Add transaction guards management
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #229
Add checks to disallow Safe as owner of itself with default methods
#229 proposes to prevent adding the Safe as an owner of itself and to check on execution if the signer is the Safe itself.
For this PR checks have been added to:
setupaddOwnerWithThresholdswapOwnerNo check has been added to the execution process, as this would prevent user from potentially recovering a Safe that has itself as an owner. To get into this state after this update you would need to use a delegate call that messes with the Safes state. This is out of scope of our checks (as we expect users to pay special attention to delegate calls)