-
Notifications
You must be signed in to change notification settings - Fork 361
Incoming transactions #164
Comments
Incoming tx in the list and notification: https://invis.io/C8TFLRFU4ZV#/384309988_28_Transactions_-incoming-_ Expanded view: https://invis.io/C8TFLRFU4ZV#/384309989_32_Transactions_-_Expand_-incoming-_ Expanded view with known address: https://invis.io/C8TFLRFU4ZV#/384309991_33_Transactions_-_Expand_-incoming_Known_Address-_ In the initial design there was a pending label, I'm not sure if we display pending incoming transactions. |
I know this is not the same as the mobile app, but in the mobile app I like that we have an easy visual way to scan the tx list and immediately tell which txs were incoming and which were outgoing (with the coloured arrows). We already have the Success/Pending/Failed part as the colour focus but I wonder if there was a way to indicate the difference between outgoing and incoming in any other way than text... Would icons clutter the list too much? |
Agree. It would be good to differentiate transactions visually. Maybe even also inidicate which transactions are smart contract interactions or settings changes. |
@lukasschor @KristinaMayman I added icons to the list https://invis.io/C8TFLRFU4ZV#/384309988_28_Transactions_-incoming-_. There is no commonly used icon for custom transactions. I used the same settings icon like in "Settings change". |
@lukasschor @KristinaMayman I have many options. I prefer the "<>" one. |
Thanks for showing all the options! I agree the "<>" one works best. |
New icon is on zeplin: https://zpl.io/2vPnBm7 |
@lukasschor, is there an endpoint in Or shall we poll for incoming Transfers in the UI only? Given this last scenario, we will have two different sources of truth ( Finally, if we go with the polling for incoming transfers approach, shall we persist those in the |
@fernandomg there's an endpoint in transaction history service: https://safe-transaction.staging.gnosisdev.com/ |
@mikheevm, thanks! 🤦♂️ |
@mikheevm, from what I can see in the response for both endpoints ( Is there a way that the |
@fernandomg let's ask @Uxio0 if adding a timestamp to the backend is easy. I wouldn't like to do it on the frontend because we poll txs every 5s and querying timestamps every 5s isn't the best thing to do. |
@fernandomg @mikheevm I sorting is the only thing you need, I can just return the |
I already added the |
What is this feature about? (1 sentence)
Display incoming transactions and notify users.
Why is it needed? What is the value? For whom do we build it?
Currently, incoming transactions are not shown, this is a major UX flaw as incoming transactions are expected from users.
High-level overview of the feature
Backend Endpoint
safe-global/safe-transaction-service#22
The text was updated successfully, but these errors were encountered: