Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Display multisend contract and add delegate warnings #3090

Closed
iamacook opened this issue Dec 1, 2021 · 0 comments · Fixed by #3093
Closed

Display multisend contract and add delegate warnings #3090

iamacook opened this issue Dec 1, 2021 · 0 comments · Fixed by #3093
Assignees
@iamacook
Labels
Critical Only for bugs in released apps, needs to be fixed asap and hotfix needs to be shipped.

Comments

@iamacook
Copy link
Member

iamacook commented Dec 1, 2021 •
edited
Loading

Overview

We have no possibility to check the correct multisend contract is being used. We should be displaying it as a standard "to" field like other transactions.

We should also add a warning for "unexpected" delegate calls. These only occur for multisends (which safe upgrades also use).

Requirements

  • Add multisend contract address transaction details, showing that it is the correct one.
  • Add warnings for unexpected delegate calls.

Links
@iamacook iamacook added the Critical Only for bugs in released apps, needs to be fixed asap and hotfix needs to be shipped. label Dec 1, 2021
@iamacook iamacook self-assigned this Dec 1, 2021
This was referenced Dec 1, 2021
Closed
Merged
@iamacook iamacook changed the title Display multisend contract being used Display multisend contract and add delegate warnings Dec 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@iamacook iamacook

Labels
Critical Only for bugs in released apps, needs to be fixed asap and hotfix needs to be shipped.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add multisend contract details and delegate call warning 5afe/safe-react
1 participant
@iamacook