This repository has been archived by the owner on Nov 10, 2023. It is now read-only.
#110 Sorting out tests: Safe creation and Safe loading, fix the validator for safe address #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis automatic deployment: Storybook book automatic deployment: |
germartinez
approved these changes
May 31, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
safe creationandsafe loadreact-testing-libraryis now used.babelrctobabel.config.jsbecause of this: babel-jest does not transpile import/export in node_modules when Babel 7 is used jestjs/jest#6229 (comment)config/andscripts/files and few more (Prettier ❤️)jest.config.jsso we can use some JS in the configurationtestIdtoStepperandGnoFormcomponent for testing purposessafeFieldsValidationfunction in Load Safe form. Previously it was retrieving an address of a proxy contract by calling.implementation()from a contract, in contractsv1.0.0it was removed, so we have to get it from contract storage. The same approach is used ingnosis-py: https://github.com/gnosis/gnosis-py/blob/master/gnosis/safe/safe.py#L449fetchTransactionaction because it broke the build, will refactor this once we get to work on transaction list