This repository has been archived by the owner on Nov 10, 2023. It is now read-only.
Switch network when shortName prefix changes #2832
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Assistant Lite All Contributors have signed the CLA. |
katspaugh
reviewed
Oct 13, 2021
e.preventDefault() | ||
clickAway() | ||
setNetwork(networkId) | ||
// setNetwork occurs via history.listen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But there's no shortName in the ROOT_ROUTE, is there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very true - thanks for catching that!
ESLint Summary View Full Report
Report generated by eslint-plus-action |
|
katspaugh
approved these changes
Oct 14, 2021
The PR is stuck loading for me: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves #2828
How this PR fixes it
A listener is attached to the history object which checks that a
shortName
exists and differs to the current config one. When it detects a change, it sets the new network.How to test it
Open a safe on one network and connect, then open a safe on another network and connect. Click the back button and you should get prompted to connect to the previous network.
Accessing a
NETWORK_ROOT_ROUTES
route, i.e..../app/polygon
sets the app to that network. The network selector in the top right should still work on these routes that have no chain prefix in the URL.