Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Show a meaningful error message on Safe creation #3271

Merged
merged 3 commits into from
Jan 12, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
26 changes: 24 additions & 2 deletions src/routes/CreateSafePage/components/SafeCreationProcess.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,28 @@ const goToWelcomePage = () => {

const sleep = (ms: number): Promise<void> => new Promise((resolve) => setTimeout(resolve, ms))

/**
* Parse MM error message, as a workaround for a bug in web3.js that doesn't do it correctly.
* It returns a formatting error like this:
*
* `[ethjs-query] while formatting outputs from RPC '{"value":{"code":-32000,"message":"intrinsic gas too low"}}'`
*/
const parseError = (err: Error): Error => {
const prefix = '[ethjs-query] while formatting outputs from RPC '

if (!err.message.startsWith(prefix)) return err

const json = err.message.split(prefix).pop() || ''
let actualMessage = ''
try {
actualMessage = JSON.parse(json.slice(1, -1)).value.message
} catch (e) {
actualMessage = ''
}

return actualMessage ? new Error(actualMessage) : err
}

function SafeCreationProcess(): ReactElement {
const [safeCreationTxHash, setSafeCreationTxHash] = useState<string | undefined>()
const [creationTxPromise, setCreationTxPromise] = useState<Promise<TransactionReceipt>>()
Expand Down Expand Up @@ -107,15 +129,15 @@ function SafeCreationProcess(): ReactElement {
resolve(txReceipt)
})
.catch((error) => {
reject(error)
reject(parseError(error))
})
})
.then((txReceipt) => {
console.log('First tx mined:', txReceipt)
resolve(txReceipt)
})
.catch((error) => {
reject(error)
reject(parseError(error))
})
}),
)
Expand Down
7 changes: 6 additions & 1 deletion src/routes/opening/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,12 @@ export const SafeDeployment = ({
if (isTxPendingError(err)) {
dispatch(enqueueSnackbar({ ...NOTIFICATIONS.TX_PENDING_MSG }))
} else {
dispatch(enqueueSnackbar({ ...NOTIFICATIONS.CREATE_SAFE_FAILED_MSG }))
dispatch(
enqueueSnackbar({
...NOTIFICATIONS.CREATE_SAFE_FAILED_MSG,
message: `${NOTIFICATIONS.CREATE_SAFE_FAILED_MSG.message} – ${err.message}`,
}),
)
}
},
[dispatch],
Expand Down