Fix bug when tx was already imported by node

5afe · Dec 14, 2018 · 70b34d6 · 70b34d6
1 parent 67b3156
commit 70b34d6
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/safe_relay_service/relay/tasks.py b/safe_relay_service/relay/tasks.py
@@ -218,8 +218,11 @@ def deploy_safes_task(retry: bool=True) -> None:
                         safe_funding.safe_deployed_tx_hash = creation_tx_hash
                         safe_funding.save()
                 except TransactionAlreadyImported:
-                    logger.warning("Safe=%s transaction was already imported by the node")
-                    return
+                    logger.warning("Safe=%s transaction was already imported by the node", safe_address)
+                    safe_funding.safe_deployed_tx_hash = safe_creation.tx_hash
+                    safe_funding.safe_deployed = False
+                    safe_funding.save()
+                    continue
                 except ValueError:
                     # Usually "ValueError: {'code': -32000, 'message': 'insufficient funds for gas * price + value'}"
                     # A reorg happened

diff --git a/safe_relay_service/version.py b/safe_relay_service/version.py
@@ -1,2 +1,2 @@
-__version__ = '2.3.2'
+__version__ = '2.3.3'
 __version_info__ = tuple([int(num) if num.isdigit() else num for num in __version__.replace('-', '.', 1).split('.')])