Add the ability to remove targets

gnosisguild · Jun 7, 2022 · 8076612 · 8076612
1 parent 04e218e
commit 8076612
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/packages/app/src/services/rolesModifierContract.ts b/packages/app/src/services/rolesModifierContract.ts
@@ -133,6 +133,9 @@ export const updateRole = async (
   const removeMemberTxs = role.members.remove.map((member) =>
     rolesModifierContract.populateTransaction.assignRoles(member, [role.id], [false]),
   )
+  const removeTargetTxs = role.targets.remove.map((target) =>
+    rolesModifierContract.populateTransaction.revokeTarget(role.id, target),
+  )
   const txs = [...role.targets.list, ...role.targets.add].map(async (target) => {
     const updateEvents = role.getTargetUpdate(target.id)
 
@@ -263,11 +266,12 @@ export const updateRole = async (
   })
 
   const targetTxs = (await Promise.all([...txs])).flat()
+  const targetActionsTxs = await Promise.all([...removeTargetTxs])
   const memberTxs = await Promise.all([...addMemberTxs, ...removeMemberTxs])
 
-  console.log("txs", [...memberTxs, ...targetTxs])
+  console.log("txs", [...memberTxs, ...targetTxs, ...targetActionsTxs])
 
-  return [...memberTxs, ...targetTxs]
+  return [...memberTxs, ...targetTxs, ...targetActionsTxs]
 }
 
 export const executeTxsGnosisSafe = async (txs: PopulatedTransaction[]) => {