add some test cases for balancer preset

gnosisguild · Jan 9, 2023 · d6bdc9c · d6bdc9c
1 parent 46f3e17
commit d6bdc9c
Show file tree

Hide file tree

Showing 4 changed files with 59 additions and 13 deletions.
diff --git a/packages/sdk/test/karpatkey/simulateTransactions.test.ts b/packages/sdk/test/karpatkey/simulateTransactions.test.ts
@@ -8,7 +8,8 @@ import gnosisChainDeFiHarvestPreset from "../../src/presets/gnosisChain/deFiHarv
 import gnosisChainDeFiManagePreset from "../../src/presets/gnosisChain/deFiManage"
 import mainnetDeFiHarvestPreset from "../../src/presets/mainnet/deFiHarvest"
 import mainnetDeFiManagePreset from "../../src/presets/mainnet/deFiManage"
-import balancerManagePreset from "../../src/presets/mainnet/deFiManageBalancer"
+import balancerManage1Preset from "../../src/presets/mainnet/deFiManageBalancer1"
+import balancerManage2Preset from "../../src/presets/mainnet/deFiManageBalancer2"
 import {
   AVATAR_ADDRESS_PLACEHOLDER,
   OMNI_BRIDGE_DATA_PLACEHOLDER,
@@ -17,7 +18,8 @@ import {
 import { RolePreset } from "../../src/types"
 import { KARPATKEY_ADDRESSES } from "../../tasks/manageKarpatkeyRoles"
 
-import balancerManageTransactions from "./testTransactions/balancerManage"
+import balancerManage1Transactions from "./testTransactions/balancerManage1"
+import balancerManage2Transactions from "./testTransactions/balancerManage2"
 import harvestMainnetTransactions from "./testTransactions/ethHarvest"
 import manageMainnetTransactions from "./testTransactions/ethManage"
 import harvestGnosisChainTransactions from "./testTransactions/gnoHarvest"
@@ -73,7 +75,13 @@ describe("Karpatkey: Simulate Transactions Test", async () => {
   }: {
     preset: RolePreset
     config: typeof KARPATKEY_ADDRESSES["DAO_GNO"]
-    transactions: { from: string; value?: string; data: string; to: string }[]
+    transactions: {
+      from: string
+      value?: string
+      data: string
+      to: string
+      expectRevert?: boolean
+    }[]
   }) => {
     const { owner, modifier } = await setup()
     const permissionUpdateTransactions = await encodeApplyPreset(
@@ -131,7 +139,15 @@ describe("Karpatkey: Simulate Transactions Test", async () => {
           ROLE_ID,
           false
         )
+
+        if (tx.expectRevert) {
+          throw new Error(`Expected revert, but tx #${i} did not revert`)
+        }
       } catch (e) {
+        if (tx.expectRevert) {
+          continue
+        }
+
         // tx failed
         console.log((e as Error).message + "\n")
         throw e
@@ -193,12 +209,22 @@ describe("Karpatkey: Simulate Transactions Test", async () => {
     })
   })
 
-  describe("Balancer Manage preset [balancer:manage]", () => {
+  describe("Balancer Manage 1 preset [balancer:manage1]", () => {
     it("allows executing all listed management transactions from the DAO Safe", async () => {
       await simulateTransactions({
         config: KARPATKEY_ADDRESSES.BALANCER_1_ETH,
-        preset: balancerManagePreset,
-        transactions: balancerManageTransactions,
+        preset: balancerManage1Preset,
+        transactions: balancerManage1Transactions,
+      })
+    })
+  })
+
+  describe("Balancer Manage 2 preset [balancer:manage2]", () => {
+    it("allows executing all listed management transactions from the DAO Safe", async () => {
+      await simulateTransactions({
+        config: KARPATKEY_ADDRESSES.BALANCER_2_ETH,
+        preset: balancerManage2Preset,
+        transactions: balancerManage2Transactions,
       })
     })
   })

diff --git a/packages/sdk/test/karpatkey/testTransactions/balancerManage.ts b/packages/sdk/test/karpatkey/testTransactions/balancerManage.ts
diff --git a/packages/sdk/test/karpatkey/testTransactions/balancerManage1.ts b/packages/sdk/test/karpatkey/testTransactions/balancerManage1.ts
@@ -0,0 +1,26 @@
+export default [
+  {
+    from: "0xa2372f3c9a26f45b5d69bd513be0d553ff9cc617",
+    to: "0x3d9819210a31b4961b30ef54be2aed79b9c9cd3b",
+    data: "0x1c3db2e0000000000000000000000000a2372f3c9a26f45b5d69bd513be0d553ff9cc617000000000000000000000000000000000000000000000000000000000000004000000000000000000000000000000000000000000000000000000000000000020000000000000000000000005d3a536e4d6dbd6114cc1ead35777bab948e3643000000000000000000000000e65cdb6479bac1e22340e4e755fae7e509ecd06c",
+  },
+  {
+    // claimComp for cAAVE
+    from: "0xa2372f3c9a26f45b5d69bd513be0d553ff9cc617",
+    to: "0x3d9819210a31b4961b30ef54be2aed79b9c9cd3b",
+    data: "0x1c3db2e0000000000000000000000000a2372f3c9a26f45b5d69bd513be0d553ff9cc61700000000000000000000000000000000000000000000000000000000000000400000000000000000000000000000000000000000000000000000000000000001000000000000000000000000e65cdb6479bac1e22340e4e755fae7e509ecd06c",
+  },
+  {
+    // claimComp for cDAI + cUSD
+    from: "0xa2372f3c9a26f45b5d69bd513be0d553ff9cc617",
+    to: "0x3d9819210a31b4961b30ef54be2aed79b9c9cd3b",
+    data: "0x1c3db2e0000000000000000000000000a2372f3c9a26f45b5d69bd513be0d553ff9cc6170000000000000000000000000000000000000000000000000000000000000040000000000000000000000000000000000000000000000000000000000000000200000000000000000000000039aa39c021dfbae8fac545936693ac917d5e75630000000000000000000000005d3a536e4d6dbd6114cc1ead35777bab948e3643",
+  },
+  {
+    // claimComp for cWBTC and cAAVE
+    from: "0xa2372f3c9a26f45b5d69bd513be0d553ff9cc617",
+    to: "0x3d9819210a31b4961b30ef54be2aed79b9c9cd3b",
+    data: "0x1c3db2e0000000000000000000000000a2372f3c9a26f45b5d69bd513be0d553ff9cc61700000000000000000000000000000000000000000000000000000000000000400000000000000000000000000000000000000000000000000000000000000002000000000000000000000000c11b1268c1a384e55c48c2391d8d480264a3a7f4000000000000000000000000e65cdb6479bac1e22340e4e755fae7e509ecd06c",
+    expectRevert: true,
+  },
+]
diff --git a/packages/sdk/test/karpatkey/testTransactions/balancerManage2.ts b/packages/sdk/test/karpatkey/testTransactions/balancerManage2.ts
@@ -0,0 +1 @@
+export default []