All tests passing! 🎉

gnosisguild · Dec 16, 2021 · efe15bb · efe15bb
1 parent 1b108b2
commit efe15bb
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/test/FactoryFriendly.spec.ts b/test/FactoryFriendly.spec.ts
@@ -30,7 +30,7 @@ describe("Module works with factory", () => {
       FirstAddress
     );
 
-    return { factory, masterCopy };
+    return { factory, masterCopy, Modifier };
   });
 
   it("should throw because master copy is already initialized", async () => {
@@ -47,7 +47,7 @@ describe("Module works with factory", () => {
   });
 
   it("should deploy new roles module proxy", async () => {
-    const { factory, masterCopy } = await baseSetup();
+    const { factory, masterCopy, Modifier } = await baseSetup();
     const [avatar, owner, target] = await ethers.getSigners();
     const paramsValues = [owner.address, avatar.address, target.address];
     const encodedParams = [new AbiCoder().encode(paramsTypes, paramsValues)];
@@ -66,7 +66,8 @@ describe("Module works with factory", () => {
       ({ event }: { event: string }) => event === "ModuleProxyCreation"
     );
 
-    const newProxy = await hre.ethers.getContractAt("Roles", newProxyAddress);
+    const newProxy = Modifier.attach(newProxyAddress);
+    // const newProxy = await hre.ethers.getContractAt("Roles", newProxyAddress);
     expect(await newProxy.avatar()).to.be.eq(avatar.address);
     expect(await newProxy.target()).to.be.eq(target.address);
   });

diff --git a/test/Roles.spec.ts b/test/Roles.spec.ts
@@ -1544,7 +1544,7 @@ describe("RolesModifier", async () => {
   describe("setMultiSend()", () => {
     it("reverts if not authorized", async () => {
       const { avatar, modifier } = await txSetup();
-      expect(modifier.setMultiSend(AddressOne, true)).to.be.revertedWith(
+      await expect(modifier.setMultiSend(AddressOne)).to.be.revertedWith(
         "Ownable: caller is not the owner"
       );
     });