check for set controller zeros

gnosisguild · May 24, 2022 · 613a106 · 613a106
1 parent c56fd79
commit 613a106
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/contracts/GnomadModule.sol b/contracts/GnomadModule.sol
@@ -115,6 +115,8 @@ contract GnomadModule is Module {
     public
     onlyOwner
   {
+    require(_controller != address(0), "Controller can not be zero address");
+    require(_controllerDomain != 0, "Controller Domain can not be zero");
     require(
       !isController(_controller, _controllerDomain),
       "controller already set to this"

diff --git a/test/GnomadModule.spec.ts b/test/GnomadModule.spec.ts
@@ -253,7 +253,7 @@ describe("GnomadModule", async () => {
       const { module, controller } = await setupTestWithTestAvatar();
       const avatarTx = await module.populateTransaction.setController(
         user2.address,
-        0
+        42
       );
       const tx = {
         to: module.address,
@@ -269,6 +269,7 @@ describe("GnomadModule", async () => {
       await module.handle(controllerDomain, 0, bytes32controller, encoded);
 
       expect(await module.controller()).to.be.equals(user2.address);
+      expect(await module.controllerDomain()).to.be.equals(42);
     });
   });
 });