Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce a distinction between Module.sol and ModuleGuardable.sol #139

Closed
wants to merge 5 commits into from
Closed

Introduce a distinction between Module.sol and ModuleGuardable.sol #139

wants to merge 5 commits into from

Conversation

cristovaoth
Copy link
Contributor

Having Modifiers and Modules being Guardable by default introduces an overhead:

  • 3kb in deployed bytecode
  • 2k GAS in every modifier call

This PR makes the default Modifier and Module non guardable. The guardable functionality is composed into ModuleGuardable and ModifierGuardable

@github-actions
Copy link

github-actions bot commented Oct 2, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6395717381

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-9.8%) to 85.027%
Totals Coverage Status
Change from base Build 6376478791: -9.8%
Covered Lines: 96
Relevant Lines: 109
💛 - Coveralls

@cristovaoth cristovaoth changed the title Lean Modifier.sol and Module.sol Introduce a distinction between Module.sol and ModuleGuardable.sol Oct 3, 2023
@cristovaoth cristovaoth closed this Oct 4, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2023
@cristovaoth cristovaoth deleted the lean-module-and-modifier branch October 4, 2023 10:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@auryn-macmillan auryn-macmillan Awaiting requested review from auryn-macmillan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@cristovaoth