Possible problem in edit manager

[desb42]

On researching #278 I stumbled across some code in Xog_tab_itm_edit_mgr.java
Line 103 reads

if (Bry_.Eq(page.Ttl().Page_db(), wiki.Props().Main_page()))

If the page is 'Main Page' then this will try to compare Main_Page with Main Page and fail
I believe using

if (Bry_.Eq(ttl.Page_db(), wiki.Props().Siteinfo_mainpage()))

will perform the correct check (which is what I do in Xow_portal_mgr.java)

Perhaps taking a leaf out of Mediawiki's book, introduce a ttl.isMainPage()?

[gnosygnu]

If the page is 'Main Page' then this will try to compare Main_Page with Main Page and fail
I believe using

if (Bry_.Eq(ttl.Page_db(), wiki.Props().Siteinfo_mainpage()))

will perform the correct check (which is what I do in Xow_portal_mgr.java)

Honestly, I really expected both to be the same. But in the end, Siteinfo_mainpage() should be correct. Main_page() should be deprecated: it's used to "override" the Main_Page that's found in the xml dump.

Perhaps taking a leaf out of Mediawiki's book, introduce a ttl.isMainPage()

It's a bit difficult. MediaWiki does this by checking the wfMessage: https://github.com/wikimedia/mediawiki/blob/master/includes/Title.php#L598

In contrast, XOWA's title object is pretty self-contained and doesn't have any dependencies on other objects. Adding a call to Xow_msg_mgr may add more headaches, especially since the Xoa_ttl class is used at such a low level