Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for kernel dependency #20

Open
hacfi opened this issue Aug 28, 2014 · 2 comments
Open

Add support for kernel dependency #20

hacfi opened this issue Aug 28, 2014 · 2 comments

Comments

@hacfi
Copy link
Contributor

hacfi commented Aug 28, 2014

We should discuss if there is an actual need for that special use-case. The only bundle I know which requires this is JMSDiExtraBundle.

If we do want support for that I think an extra parameter will be the simplest solution. Then we simple modify Gnugat\ComposerPlugin\WizardPlugin\GnugatWizardPlugin::enablePackage so it checks for that extra parameter and then pass true/false to $kernelManipulator->addBundle($bundle->fullyQualifiedClassname, $requireKernel);

@gnugat
Copy link
Collaborator

gnugat commented Aug 28, 2014

Thanks for your interest in that specific feature!

Are you suggesting to add this kind of parameter in JMSDiExtraBundle? This might be inconvenient to ask every bundle creator to add a parameter just to comply with the Wizard.

Another option would be to create in our side a way to detect kernel dependency (a naive strategy would be to use a hardcoded list of bundles, but it could evolve into something smarter).

In any case, this means that the Wizard will need to have its own KernelManipulator (and this is exactly why I decided to create the Redaktilo project).

@hacfi
Copy link
Contributor Author

hacfi commented Aug 28, 2014

Yes, my idea was it to specify the dependency in the composer.json of the external bundle. As this feature will go into symfony-standard I’m sure Johannes won’t mind adding the extra parameter.

It was just an idea..I’d be fine if we say that we won’t support dependencies.

I’ll have a closer look at Redaktilo soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants