You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We should discuss if there is an actual need for that special use-case. The only bundle I know which requires this is JMSDiExtraBundle.
If we do want support for that I think an extra parameter will be the simplest solution. Then we simple modify Gnugat\ComposerPlugin\WizardPlugin\GnugatWizardPlugin::enablePackage so it checks for that extra parameter and then pass true/false to $kernelManipulator->addBundle($bundle->fullyQualifiedClassname, $requireKernel);
The text was updated successfully, but these errors were encountered:
Thanks for your interest in that specific feature!
Are you suggesting to add this kind of parameter in JMSDiExtraBundle? This might be inconvenient to ask every bundle creator to add a parameter just to comply with the Wizard.
Another option would be to create in our side a way to detect kernel dependency (a naive strategy would be to use a hardcoded list of bundles, but it could evolve into something smarter).
In any case, this means that the Wizard will need to have its own KernelManipulator (and this is exactly why I decided to create the Redaktilo project).
Yes, my idea was it to specify the dependency in the composer.json of the external bundle. As this feature will go into symfony-standard I’m sure Johannes won’t mind adding the extra parameter.
It was just an idea..I’d be fine if we say that we won’t support dependencies.
We should discuss if there is an actual need for that special use-case. The only bundle I know which requires this is JMSDiExtraBundle.
If we do want support for that I think an extra parameter will be the simplest solution. Then we simple modify Gnugat\ComposerPlugin\WizardPlugin\GnugatWizardPlugin::enablePackage so it checks for that extra parameter and then pass true/false to
$kernelManipulator->addBundle($bundle->fullyQualifiedClassname, $requireKernel);
The text was updated successfully, but these errors were encountered: