Sensio Kernel Manipulator false return value not handled

[rrajkomar]

In your bundle (which is great BTW), the following method return value is not checked :
$kernelManipulator->addBundle($bundle->fullyQualifiedClassname);

This method can return false, in which case the bundle is not registered and yet your bundle would return a success !

[gnugat]

Hello @rrajkomar thanks for your comment, you're right we should check it.

However this bundle is kind of doomed as I still haven't found a way to make it work with PSR-4 (it only works with PSR-0 which is now deprecated), so unless we find a solution for this I don't intend to further maintain it... But I'd love to review and merge Pull requests!

Cheers,

[rrajkomar]

What's the issue with psr-4? Your code should be working (haven't tested it though yet).

[gnugat]

While trying to write an answer for you, I've found it difficult to remember the issue. And by looking at the code it really looks like it should be working!
This needs more care I guess, when I have time I'll have a closer look at it and if it turns out everything works I'll improve it :)