Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CORS access for all domains #32

Open
dylanede opened this issue Mar 17, 2016 · 6 comments
Open

Enable CORS access for all domains #32

dylanede opened this issue Mar 17, 2016 · 6 comments

Comments

@dylanede
Copy link

I'd like to use the clippy.bashy.io service from a GitHub pages site, so enabling access to logs from pages from domains other than clippy.bashy.io would be great.

@gnunicorn
Copy link
Owner

Hi @dylanede,

at this very moment, I am hesitant to enable CORS as that could easily (unintentionally) DDOS us – at least until #15 is fixed. However, your request is very intriguing, what are you planning to do with it?

@dylanede
Copy link
Author

Well, there's not much to it at the moment, but the idea is to make an interface for the log that makes it easier to read and shows the relevant source code and highlighted regions. At the moment I've got extraction from the log working. I haven't put it on GHP yet but here's the source:

https://github.com/dylanede/pretty-clippy

At the moment it uses alloworigin.com to access clippy.

@gnunicorn
Copy link
Owner

Ah, nice @dylanede . Did you know, there was a (help-wanted) bug report to create a prettier log within clippy itself: #21 ? You wouldn't be interested in pushing this effort forward here, would you?

Among other things I wanted to make the logs more informative, provide it as one big json with actual objects in it – including the exact clippy messages with all the glory information they come with. Right now I am a little pre-occupied with other things, but if I saw progress on the HTML-UI, I'd be very motivated to get this efforts going!

@dylanede
Copy link
Author

Currently this is just a little side project for me - a learning tool. I'm not very experienced with webdev. I do however really like Elm, so I'll see how far I can get with this. My next task will be to take the span information and figure out which contiguous regions of source files to show (multiple messages per region), then read the files from GitHub. Current layout idea is to have source file regions on the left, with messages on the right lined up to the correct lines in the source.

@dylanede
Copy link
Author

So to answer your question: I don't feel experienced enough to be responsible for #21 in-tree, but I'll happily tinker away at it in my repo in my spare time until I'm happy with it.

@gnunicorn
Copy link
Owner

@dylanede sure. Just keep us posted about the progress and we'll see how we can help :) .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants