Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quake mode produces instances until crash #1275

Closed
aleho opened this issue Jan 29, 2018 · 11 comments
Closed

Quake mode produces instances until crash #1275

aleho opened this issue Jan 29, 2018 · 11 comments

Comments

@aleho
Copy link

aleho commented Jan 29, 2018

Using tilix with a key-binding on tilix --quake each hit on the shortcut will cause another instance to run.

This can be observed by executing tilix --quake in an already open Quake-Mode-Instance. The window is hidden, but after opening it again you can see the command is still being executed.

After a few instances of Tilix it crashes because of some limits.

@gnunn1
Copy link
Owner

gnunn1 commented Jan 30, 2018

I cannot reproduce it on Arch Linux and Gnome 3.26, what desktop environment are you using? Also, what is the output of tilix --version.

Running tilix --quake will always cause a new process to run but it should be transient, it detects there is already an instance of tilix running and shuts down. Tilix uses GtkApplication to enforce a single process.

After hitting the key-binding a few times, if you run ps -ef | grep tilix you should see only one process of tilix running, is that not the case?

@aleho
Copy link
Author

aleho commented Jan 30, 2018

I'm on Debian/sid with Gnome 3.26. This happens on three of my machines, so it could be related to a recent change in Debian?

The process just hangs there. It does trigger the action (hide / unhide), it just doesn't ever stop.

Tilix output:

Versions
	Tilix version: 1.7.6-0.0.1
	VTE version: 0.50
	GTK Version: 3.22.26

Tilix Special Features
	Notifications enabled=0
	Triggers enabled=0
	Badges enabled=0

@gnunn1
Copy link
Owner

gnunn1 commented Jan 30, 2018

Does it make any difference if you set DBusActivatable to false in the desktop file?

@aleho
Copy link
Author

aleho commented Jan 31, 2018

Nope. Also, I'm starting Tilix directory from the Alt+F2 prompt (or any other terminal).

What I also noticed: Executing tilix --quake & in Gnome terminal and then exiting (Ctrl+D) the process is stopped and there's an output: GDBus.Error:org.freedesktop.DBus.Error.NoReply: Message recipient disconnected from message bus without replying.

Simply toggling Tilix with the shortcut (which executes "tilix --quake") I get multiple instances of it, each for every toggle.

@aleho
Copy link
Author

aleho commented Feb 1, 2018

Doing a git-bisect run I found the culprit: d705f04

Reverting it fixes the issues. The lag I noticed recently (tilix --quake seems to need a second to show the window) is also gone.

@gnunn1
Copy link
Owner

gnunn1 commented Feb 3, 2018

Any chance you are compiling tilix yourself, I wonder if this is related to the version of GtkD used as there were some issues around this that I believe are corrected in the latest version.

If you are compiling it, are you using autotools or dub?

@aleho
Copy link
Author

aleho commented Feb 3, 2018

I'm compiling it myself or else couldn't have done the bisect run, but was using the version supplied in Debian before. ;)

As far as I can tell the Debian package uses autotools.

GtkD is at version 3.7.1-1+b1 in Debian/sid. I haven't upgraded or changed any of the libraries needed to compile Tilix.

@gnunn1
Copy link
Owner

gnunn1 commented Feb 3, 2018

The latest release of GtkD is 3.7.3, please try against that as there were some issues in 3.7.1 and 3.7.2 with respect to tilix. You can use dub to do the build using:

dub build --build=release --compiler=ldc2

@aleho
Copy link
Author

aleho commented Feb 5, 2018

I actually "just" upgraded the Debian package of gtk-d to make sure it's not related to any other package.

Good catch, it actually was the outdated gtk-d lib. I'm going to file a bug report at Debian, their official package of 1.7.5 should be broken too.

@aleho aleho closed this as completed Feb 5, 2018
@aleho
Copy link
Author

aleho commented Feb 7, 2018

@gnunn1
Copy link
Owner

gnunn1 commented Feb 7, 2018

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants