Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quake mode switch disables app menu/icon under GNOME 3.20 #471

Closed
anassahmed opened this issue Sep 11, 2016 · 10 comments
Closed

Quake mode switch disables app menu/icon under GNOME 3.20 #471

anassahmed opened this issue Sep 11, 2016 · 10 comments

Comments

@anassahmed
Copy link

I'm using Fedora 24 + GNOME 3.20 + Wayland. I assigned a hotkey for terminx --quake and it worked for the first time amazingly.

Then when I switched back to it (toggled the window visibility using the hotkey), the app menu (in GNOME Shell top bar) has become one option (Quit) and the app name became "terminix" (starting with small letter) with a generic app icon!

Before switching the visibility:
screenshot from 2016-09-11 20-20-31

After switching the visibility:
screenshot from 2016-09-11 20-20-14

@gnunn1
Copy link
Owner

gnunn1 commented Sep 11, 2016

I checked in some new code about an hour ago, can you check that out and see if it fixes the issue as it seems fine to me. Still have a focus issue to work on though.

@gnunn1 gnunn1 added the bug label Sep 11, 2016
@gnunn1
Copy link
Owner

gnunn1 commented Sep 11, 2016

I spoke too soon, I can replicate this under Wayland. No clue as to what the solution is though, It will need more investigation. Might also be a bug with gnome-shell.

@gnunn1 gnunn1 mentioned this issue Sep 12, 2016
@gnunn1
Copy link
Owner

gnunn1 commented Sep 12, 2016

Filed an upstream bug for this:

https://bugzilla.gnome.org/show_bug.cgi?id=771329

@gnunn1
Copy link
Owner

gnunn1 commented Sep 13, 2016

So upstream responded, doesn't look the two methods I'm using in x11 to hide from the pager and taskbar work in Wayland. The other issue is there may be a bug in Wayland with the appmenu when a window is hidden and shown, if the hide from taskbar worked you would never see the appmenu in Wayland so it would be a non-issue.

I'll build a simple reproducer for the hide/show and open a new bug against gnome-shell if I can reproduce it,

@gnunn1
Copy link
Owner

gnunn1 commented Sep 15, 2016

I notice lollypop has issues as well with the appmenu under Wayland when you set the option for continuous playback where the app keeps running.

@gnunn1
Copy link
Owner

gnunn1 commented Sep 15, 2016

One more upstream bug filed:

https://bugzilla.gnome.org/show_bug.cgi?id=771492

@anassahmed
Copy link
Author

I've switched to X11 with the latest code (1.3.0) and tested it again but I noticed that there's no app menu at all!

screenshot from 2016-09-18 23-53-09

@gnunn1
Copy link
Owner

gnunn1 commented Sep 18, 2016

Yes, that's always been the intent as nothing in the application menu is very useful since the quake window is an always-on-top window. Opening things like Preferences and Shortcuts makes them appear under the quake'ed terminix window. I'm open to having a discussion about it though.

Unfortunately Wayland doesn't respect the taskbar and pager hints which is the only reason it shows up there.

@anassahmed
Copy link
Author

Oh, I didn't know that because I used it for the first time under Wayland. 😄

I don't have issue with that really, but it was only an observation.

@gnunn1
Copy link
Owner

gnunn1 commented Sep 18, 2016

No worries, I'll freely admit I'm not a user of drop down terminals so the way features are presented may not be aligned with users expectations, hence why I'm happy to have a discussion about it.

Anyway, I'm going to close this issue since under Wayland it appears to be an upstream issue since I can reproduce it with three different applications (Terminix, Geary and Lollypop).

@gnunn1 gnunn1 closed this as completed Sep 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants