You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
sample_unbiased is used nowhere within fastnoise_source itself, but only as library function from cfo_channel_model and sro_channel_model.
Although removing sample_unbiased from fastnoise_source is an API-changing break, a fix for this would imho not constitute a practically API breaking change, as my wild guess is that no one but GR itself uses this obscure public method :)
As a stochastic side remark: not quite sure why it was opted to go with a precomputed random pool for offline channel simulations – if anywhere, that's where one would notice (and maybe misinterpret) the autocorrelation properties of the pool.
The text was updated successfully, but these errors were encountered:
sample_unbiased is used nowhere within fastnoise_source itself, but only as library function from cfo_channel_model and sro_channel_model.
Although removing sample_unbiased from fastnoise_source is an API-changing break, a fix for this would imho not constitute a practically API breaking change, as my wild guess is that no one but GR itself uses this obscure public method :)
As a stochastic side remark: not quite sure why it was opted to go with a precomputed random pool for offline channel simulations – if anywhere, that's where one would notice (and maybe misinterpret) the autocorrelation properties of the pool.
The text was updated successfully, but these errors were encountered: