Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fastnoise_source.sample_unbiased should be part of gr::random, not gr::fastnoise_source #1560

Open
marcusmueller opened this issue Jan 27, 2018 · 1 comment

Comments

@marcusmueller
Copy link
Member

marcusmueller commented Jan 27, 2018

sample_unbiased is used nowhere within fastnoise_source itself, but only as library function from cfo_channel_model and sro_channel_model.

Although removing sample_unbiased from fastnoise_source is an API-changing break, a fix for this would imho not constitute a practically API breaking change, as my wild guess is that no one but GR itself uses this obscure public method :)

As a stochastic side remark: not quite sure why it was opted to go with a precomputed random pool for offline channel simulations – if anywhere, that's where one would notice (and maybe misinterpret) the autocorrelation properties of the pool.

@marcusmueller marcusmueller added this to the Release 3.8 milestone Feb 16, 2018
@devnulling devnulling added this to To do in Release 3.9 via automation Jan 5, 2020
@marcusmueller marcusmueller modified the milestones: Release 3.9, 3.10.0.0 Jan 16, 2021
@marcusmueller
Copy link
Member Author

persists

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Release 3.9
  
To do
Development

No branches or pull requests

2 participants