Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GRC: py2/py3 compat #1929

Closed
noc0lour opened this issue Jul 30, 2018 · 4 comments
Closed

GRC: py2/py3 compat #1929

noc0lour opened this issue Jul 30, 2018 · 4 comments
Assignees
@marcusmueller
Labels
GRC Python
Milestone
Release 3.8+

Comments

@noc0lour
Copy link
Member

Follow up of #1915.

Using json dump(s)/load(s) Python2/Python3 has some incompabilities regarding strings/unicode.
We need to solve them for GRC & in other places in the codebase.
@noc0lour noc0lour added the next label Jul 30, 2018
@noc0lour noc0lour added this to the Release 3.8 milestone Jul 30, 2018
@noc0lour
Copy link
Member Author

noc0lour commented Aug 5, 2018

#1930 solves the issue for the GRC block cache

@marcusmueller
Copy link
Member

marcusmueller commented Aug 18, 2018 •
edited

Does that imply that merging #1930 closes this? (if so, please close ❤️)

@noc0lour
Copy link
Member Author

Need to look through the code if we have some more dump/load things we did not hit yet.

@noc0lour noc0lour self-assigned this Aug 18, 2018
@noc0lour noc0lour assigned marcusmueller and unassigned noc0lour Aug 1, 2019
@dkozel
Copy link
Contributor

dkozel commented Mar 27, 2020

Pretty sure this is long solved. maint-3.8 has been working py2/3 and master is Python 3 only.

@dkozel dkozel closed this as completed Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcusmueller marcusmueller

Labels
GRC Python
Projects
None yet
Milestone
Release 3.8+
Development

No branches or pull requests
3 participants
@dkozel @marcusmueller @noc0lour