Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VOLK modules collide with VOLK #109

Closed
n-west opened this issue Feb 24, 2017 · 1 comment
Closed

VOLK modules collide with VOLK #109

n-west opened this issue Feb 24, 2017 · 1 comment
Assignees

Comments

@n-west
Copy link
Member

n-west commented Feb 24, 2017

Creating a VOLK module has at minimum the following conflicts with VOLK:

  • VolkConfig.cmake rather than Volk_modulenameConfig.cmake is created and populated without the modulename variables
  • the installed volk_modulename/volk_modulename.h uses an ifdef guard defined by volk rather than a module defined includeguard
@n-west n-west self-assigned this Feb 24, 2017
@n-west
Copy link
Member Author

n-west commented Mar 13, 2017

fixed in 5af8aa4 and 663dbd0

@n-west n-west closed this as completed Mar 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant