Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create volk_32f_sincos_32cf kernel #476

Open
dernasherbrezon opened this issue May 25, 2021 · 2 comments
Open

Create volk_32f_sincos_32cf kernel #476

dernasherbrezon opened this issue May 25, 2021 · 2 comments
Labels
Enhancement new kernel entirely or for some specific ARCH

Comments

@dernasherbrezon
Copy link
Contributor

dernasherbrezon commented May 25, 2021 •
edited

Sometimes both sin and cos are needed (i.e. frequency modulation), so having a function that calculates both is a nice to have feature.

Besides some of kernels already calculate them:

volk/include/volk/volk_neon_intrinsics.h

Line 186 in c9d42a4

static inline float32x4x2_t _vsincosq_f32(float32x4_t x)

Also some other DSP-related frameworks normally provide such function:
https://developer.apple.com/documentation/accelerate/1470346-vvsincos
@dernasherbrezon dernasherbrezon changed the title Create volk_32f_sincos_32f kernel Create volk_32f_sincos_32cf kernel May 26, 2021
@jdemel jdemel added the Enhancement new kernel entirely or for some specific ARCH label May 26, 2021
@jdemel
Copy link
Contributor

jdemel commented May 26, 2021

I agree this is a desirable feature.

@rear1019
Copy link
Contributor

As a workaround volk_32fc_s32fc_x2_rotator_32fc() can be used. Pass a vector consisting of 1 + j·0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement new kernel entirely or for some specific ARCH
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dernasherbrezon @jdemel @rear1019