Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.8 doesn't seem to have the CMake fix #2

Closed
vincentwoo opened this issue Aug 6, 2015 · 5 comments
Closed

1.8 doesn't seem to have the CMake fix #2

vincentwoo opened this issue Aug 6, 2015 · 5 comments

Comments

@vincentwoo
Copy link

You added this patch on your fork: davidchisnall/libobjc2@71c1437 that I thought would be in 1.8, but it doesn't appear to be there. Was this intentional? It's preventing me from building on newer Clang.
@davidchisnall
Copy link
Member

Ooops. I forgot to merge those changes. I'll push out a 1.8.1 this weekend with the fixes.

Sorry!

@vincentwoo
Copy link
Author

Thanks, really appreciate it.

@davidchisnall
Copy link
Member

I've pushed the changes into master and the 1.8.1 branch. Can you test and let me know if anything else is broken? I'll aim to tag the 1.8.1 version as the current 1.8.1 branch if it's all sensible.

@vincentwoo
Copy link
Author

seems to do the trick!

@davidchisnall
Copy link
Member

Thanks. I've now pushed out the release and updated the FreeBSD port. Package should be built in the next couple of days.

@dlobron dlobron mentioned this issue Jun 20, 2016
Closed
@BertrandDekoninck BertrandDekoninck mentioned this issue Mar 24, 2018
Closed
@applesnake applesnake mentioned this issue Dec 17, 2018
Closed
@cyclaero cyclaero mentioned this issue Feb 13, 2019
Closed
@minusbat minusbat mentioned this issue Jun 28, 2019
Open
@davidchisnall davidchisnall mentioned this issue Sep 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davidchisnall @vincentwoo