Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSCircularBezelStyle should cut text #224

Closed
optimisme opened this issue Dec 22, 2023 · 5 comments
Closed

NSCircularBezelStyle should cut text #224

optimisme opened this issue Dec 22, 2023 · 5 comments
Labels
bug A bug, but not a show stopper

Comments

@optimisme
Copy link

NSCircularBezelStyle should cut text if necessary

The image on the left shows 'GNUStep' interpretation of the circular bezel style with the text 'Circular' but the image on the right is the desired visualization only showing 'Ci'

Screenshot 2023-12-22 at 11 45 41
@gcasa
Copy link
Member

gcasa commented Dec 22, 2023

GNUstepCircularButton
The above is how the default theme draws it... while this is likely incorrect since it STRETCHES the circle I am not sure where the behavior you're seeing is coming from.

The image on the left is NOT GNUstep or it is at the very least a THEME on GNUstep. Either way, and I asked this before, what theme or OS are you using to produce the images you're presenting? This is not a denial of any issue on our part... merely a request for complete information.

@gcasa
Copy link
Member

gcasa commented Dec 22, 2023

Please help me understand.... the reason I am asking is that it would be helpful to load the theme you're using and see precisely where either GS or the theme are going wrong. Thx

@gcasa
Copy link
Member

gcasa commented Dec 22, 2023

Also, can you attach a test program that illustrates what you're seeing above. (hopefully the one you're using)

@gcasa gcasa added the bug A bug, but not a show stopper label Dec 22, 2023
@optimisme
Copy link
Author

In my image, the left one (the wrong one) comes from this theme (in development)
https://github.com/optimisme/GNUStep-Theme
the right image comres from the same application rendered by macOS

@fredkiefer
Copy link
Member

This is rather an issue in your own theme. The code there does not inset the frame of the menu item cell to the frame left inside of the circle. Please have a look at the code inside of GSThemeDrawing.m in GNUstep. There you can see how the variable frame gets adjusted.
I will close this issue as it is not caused by GNUstep itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug, but not a show stopper
Development

No branches or pull requests

3 participants