Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

registration.Resource is marked for deprecation - what to use instead? #855

Closed
bouwerp opened this issue Apr 15, 2019 · 3 comments · Fixed by #924
Closed

registration.Resource is marked for deprecation - what to use instead? #855

bouwerp opened this issue Apr 15, 2019 · 3 comments · Fixed by #924
Assignees
Labels

Comments

@bouwerp
Copy link

bouwerp commented Apr 15, 2019

What should be used instead of the acme.User implementation once registration.Resource has been deprecated?

@bouwerp bouwerp closed this as completed Apr 15, 2019
@bouwerp bouwerp reopened this Apr 15, 2019
@ldez ldez self-assigned this Apr 15, 2019
@ldez ldez added the question label Apr 15, 2019
@siennathesane
Copy link

@ldez can you please provide some commentary on this?

@ldez
Copy link
Member

ldez commented Jun 10, 2019

Hi all,

I deprecated registration.Resource because I think it's not a good abstraction of the Account.

For now, I don't have a clear idea about the replacement, but I know that I want to replace it.

Maybe I marked registration.Resource as deprecated too soon but I want to "freeze" changes on this structure to force us to rethink it.

@siennathesane
Copy link

I think it might be good to clarify that the intent is to freeze in the documentation and remove the deprecation warning until you are ready to deprecate it. Since modules provide versioning, if you use the library before the formal deprecation, then you'll be fine with doc strings covering intent, if you use the library after the deprecation, then you'd get the warnings from tooling. It's not a very nice user experience when my IDE throws deprecation warnings for things with no replacements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

3 participants