Skip to content
This repository has been archived by the owner on Feb 16, 2022. It is now read-only.

Differences between GET /api/v2/users/{id}/logs and GET /api/v2/logs #130

Closed
chuyeow opened this issue Jul 22, 2020 · 2 comments
Closed

Comments

@chuyeow
Copy link

chuyeow commented Jul 22, 2020

I noticed that this client library does not implement the GET /api/v2/users/{id}/logs endpoint that returns log events for a single user.

Is this because I can use the GET /api/v2/logs endpoint with q=user_id:{id} to get the exact same response?

The API docs aren't super clear on why there could be 2 ways to do the same thing, and I'd like to confirm before I start using this library to get a user's log events, thank you!

@alexkappa
Copy link
Contributor

Hi @chuyeow, I'm not sure myself if there are other differences other than what you mentioned.

The idea is that the sdk should be aligned with the api as closely as possible. So if the functionality is missing, we should probably add it.

Feel free to submit a PR if this functionality is important to you, otherwise I'll get to it at some point.

@alexkappa
Copy link
Contributor

Closing this as the functionality seems to be available.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants