Skip to content
This repository has been archived by the owner on Feb 16, 2022. It is now read-only.

Ticket.ChangePassword doesn't return the response #252

Closed
nicolaigj opened this issue Nov 25, 2021 · 3 comments
Closed

Ticket.ChangePassword doesn't return the response #252

nicolaigj opened this issue Nov 25, 2021 · 3 comments

Comments

@nicolaigj
Copy link

Description

In the API documentation the endpoint tickets/password-change responds with a ticket URL that we can distribute to the user, but the SDK only returns an error value. The ChangePassword-function has no value when the ticket isn't returned and there is no other way of getting it (I think?).

Affected Resources

  • management.Ticket.ChangePassword

Potential Sample Code

References

https://auth0.com/docs/api/management/v2#!/Tickets/post_password_change

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@nicolaigj nicolaigj added the enhancement New feature or request label Nov 25, 2021
@nicolaigj
Copy link
Author

nicolaigj commented Nov 25, 2021

Well, after reading the source code I found out that the response is indeed returned by altering the input ticket, so it works. But it could be clearer documentation, or better separation between request and response.

If you want, I can make a proposal!

@alexkappa
Copy link
Contributor

alexkappa commented Dec 14, 2021

Hi @nicolaigj, the general behavior of this package will not return an entity upon creation, but the entity passed by reference is updated with additional fields.

The usage and examples on pkg.go.dev were meant to demonstrate how this works, but I agree with you that this could be more explicit.

At this point, changing the signature of the entire package would be a significant undertaking, but if you would like to suggest something, by all means, feel free to do so!

@sergiught
Copy link
Collaborator

Closed and cloned this issue to auth0/go-auth0#20

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants