Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tag proper v1.1.0 version #115

Closed
sagikazarmark opened this issue Jun 6, 2020 · 2 comments
Closed

Tag proper v1.1.0 version #115

sagikazarmark opened this issue Jun 6, 2020 · 2 comments
Assignees
@bkielbasa
Labels
enhancement New feature or request

Comments

@sagikazarmark
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
There are two issues with the latest 1.1 version:

  • go modules doesn't play nice with partial semver tags
  • the tag actually contains a dot before the version v.1.1

This causes an ugly version in the go.mod file:

	github.com/go-bdd/gobdd v1.0.2-0.20200601143550-b30291a8ec6c

Describe the solution you'd like
Tag a proper v1.1.0 version
@sagikazarmark sagikazarmark added the enhancement New feature or request label Jun 6, 2020
@bkielbasa
Copy link
Collaborator

Done https://github.com/go-bdd/gobdd/releases/tag/v1.1.0

@sagikazarmark
Copy link
Collaborator Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bkielbasa bkielbasa

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sagikazarmark @bkielbasa