Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WithIgnoredTags does not consider feature tags #119

Closed
jirikuncar opened this issue Jun 30, 2020 · 2 comments · Fixed by #120
Closed

WithIgnoredTags does not consider feature tags #119

jirikuncar opened this issue Jun 30, 2020 · 2 comments · Fixed by #120
Labels
bug Something isn't working

Comments

@jirikuncar
Copy link
Collaborator

jirikuncar commented Jun 30, 2020

Describe the bug (or feature)
The feature tags are not considered by gobdd.WithIgnoredTags([]string{"@todo"}).

To Reproduce

Does not work:

@todo
Feature: Tagging example

  Scenario: Do not run yet feature is still in TODO
    When it has tag todo
    Then do not run this test

This one works:

Feature: Tagging example

  @todo
  Scenario: Do not run yet feature is still in TODO
    When it has tag todo
    Then do not run this test

Expected behavior

Skip all scenarios.

Additional context

It would be nice to have access to feature and scenario tags from step functions.

@jirikuncar jirikuncar added the bug Something isn't working label Jun 30, 2020
@sagikazarmark
Copy link
Collaborator

I wouldn't classify this as a bug, but as a feature request it makes sense.

@bkielbasa
Copy link
Collaborator

I'd say it's a bug. I'm fixing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants