Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Too many new dependencies for last v1.24.0 #465

Closed
stokito opened this issue May 5, 2023 · 4 comments
Closed

Too many new dependencies for last v1.24.0 #465

stokito opened this issue May 5, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@stokito
Copy link

stokito commented May 5, 2023

I just updated the gocron and my go.sum just exploded with dozen of new dependecies like redis etc.
Is it possible to reduce the dependencies and move them to a some plugin?
@stokito stokito added the enhancement New feature or request label May 5, 2023
@JohnRoesler
Copy link
Contributor

@stokito thanks for pointing that out. Good suggestion. I think the locker implementations could live in separate plugin modules and then be imported.

@JohnRoesler JohnRoesler mentioned this issue May 5, 2023
Merged
2 tasks
@JohnRoesler
Copy link
Contributor

Pull the latest and you should get only the modules that were there before

@stokito
Copy link
Author

stokito commented May 5, 2023

All works fine, thank you for your work and for the quick response!

@JohnRoesler
Copy link
Contributor

You’re welcome. Thanks for bringing it up and updating so promptly! It’s always helpful to hear from people who use the library!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stokito @JohnRoesler