separate FileRequest from FileResponse #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go-cristian
requested changes
Apr 20, 2022
There was a problem hiding this comment.
Thanks, @felipeska for this restructure, I think changing the naming is valuable here. I would ask for this change and for sure this will be merged.
| import okhttp3.ResponseBody.Companion.toResponseBody | ||
|
|
||
| data class FileRecorded( | ||
| val responseRecorded: FileResponse, |
There was a problem hiding this comment.
I like this naming convention, can we use it for the typings too?
maybe something like RecordedResponse & RecordedRequest is more accurate.
There was a problem hiding this comment.
absolutely! I changed the file names to be more accurate.
felipeska
force-pushed
the
structure_changes
branch
from
dd393af
to
fa65a7a
Compare
go-cristian
approved these changes
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @go-cristian some changes here:
requestproperty fromFileResponse.responseproperty fromFileResponsetobody.FileRecorded.