Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore generated files or specific directory? #1313

Closed
tonsV2 opened this issue Feb 17, 2023 · 2 comments · Fixed by #1327
Closed

Ignore generated files or specific directory? #1313

tonsV2 opened this issue Feb 17, 2023 · 2 comments · Fixed by #1327
Labels
question Further information is requested

Comments

@tonsV2
Copy link

tonsV2 commented Feb 17, 2023

Forgive me is this is documented somewhere but is there a way to ignore generated files? I have a bunch of files generated by swagger that I'd like to ignore. This could either be done by ignoring generated files as seen here or ignoring a specific list of directories
@cristaloleg
Copy link
Member

I see we've framework/lintmain/internal/check/check.go:130 which should skip that. I will take a look.

As a quick fix you can use golangci-lint and ignore generated files by pattern.

@cristaloleg cristaloleg added the question Further information is requested label Feb 17, 2023
@cristaloleg cristaloleg mentioned this issue Feb 25, 2023
Merged
@cristaloleg
Copy link
Member

This PR should fix that, can you check it please? #1327

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cmd/gocritic: use checkGenerated flag properly go-critic/go-critic
2 participants
@tonsV2 @cristaloleg