We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When pulling or cloning from a repo, go-git will update submodules if the option is set.
The problem is when calling (*Worktree).updateSubmodules. It doesn't take the context from a caller.
(*Worktree).updateSubmodules
go-git/worktree.go
Lines 151 to 158 in c7feada
It creates new context internally.
go-git/submodule.go
Lines 298 to 301 in c7feada
This can lead to situations where we can't gracefully handle slow fetching of submodules or etc.
Is there any reason that it ignores context from caller? If there isn't, I think we better pass context to the funciton.
The text was updated successfully, but these errors were encountered:
No branches or pull requests
When pulling or cloning from a repo, go-git will update submodules if the option is set.
The problem is when calling
(*Worktree).updateSubmodules
. It doesn't take the context from a caller.go-git/worktree.go
Lines 151 to 158 in c7feada
It creates new context internally.
go-git/submodule.go
Lines 298 to 301 in c7feada
This can lead to situations where we can't gracefully handle slow fetching of submodules or etc.
Is there any reason that it ignores context from caller?
If there isn't, I think we better pass context to the funciton.
The text was updated successfully, but these errors were encountered: