Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and improve currentServiceMethodName() for gccgo #2

Open
dimitern opened this issue Feb 22, 2015 · 0 comments
Open

Fix and improve currentServiceMethodName() for gccgo #2

dimitern opened this issue Feb 22, 2015 · 0 comments
Assignees

Comments

@dimitern
Copy link

In goose/testservices/hook/service_gccgo.go there is some logic to extract the method name using the call stack from the runtime package. This works well for the default gc compiler, bug causes test failures with gccgo compiler, e.g. on ppc64el - http://paste.ubuntu.com/10356017/ This happens regularly in Juju CI tests (job: run-unit-tests-trusty-ppc64el-lxc). After looking through the code I found that I can reproduce the same error locally on a trusty amd64 machine, using go test -check.v -check.f TestBootstrapFailsWhenPublicIPError -compiler gccgo: http://paste.ubuntu.com/10356073/

I have a patch in mind which should resolve this, but I'm still testing it as I'm hitting random failures with gccgo as described in this bug https://bugs.launchpad.net/ubuntu/+source/gccgo-go/+bug/1393825

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant