Client re-auth failures

[wallyworld]

The symptom is that pushes of resources (or even charms) to the staging charmstore fails.

The problem is though to be here https://github.com/go-goose/goose/blob/v2/client/client.go#L219.
In the case where it has an expired authentication token then performs the first PUT get's an authorization failure re-authorizes with keystone and just tries again, without ever trying to reset the reader containing the request body, as it's already read it once it's at EOF and thus fails on the second attempt.

[mitechie]

@hmlanigan can you please look at this bug first before the lxd issues for the week?

Thanks

[hmlanigan]

started looking

[hmlanigan]

@wallyworld, I agree that the goose client doesn't correctly reset an resp.Body for reuse, but i haven't found the linkage from goose/swift to the charmstore yet?

[hmlanigan]

the last version of charmstore that used goose/swift is 5.3.1

[mhilton]

#70 contains a potential fix for this.