Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behavior of .Not(Where().Or()) has changed #6942

Closed
tsurunoyu opened this issue Apr 5, 2024 · 2 comments · Fixed by #6984
Closed

Behavior of .Not(Where().Or()) has changed #6942

tsurunoyu opened this issue Apr 5, 2024 · 2 comments · Fixed by #6984
Assignees
Labels
type:with reproduction steps with reproduction steps

Comments

@tsurunoyu
Copy link

GORM Playground Link

go-gorm/playground#711
go-gorm/playground#710

Description

This is related to #6845.

The behavior of .Not(DB.Where().Or()) has changed.

In the sample code,

for v1.25.5, the playground code produces: WHERE NOT (name = 'a' OR name = 'b')
for master, the playground code produces: WHERE NOT (name = 'a' AND name = 'b')

@github-actions github-actions bot added the type:with reproduction steps with reproduction steps label Apr 6, 2024
@albert-anzenna
Copy link

@jinzhu and @gg1229505432 any updates on this issue? We are aware of this issue and we think this issue was not fixed in the quoted commits.

@gg1229505432
Copy link

I'm not being pulled into the contributor list, so I don't have permission to merge code 🧐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:with reproduction steps with reproduction steps
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants