Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poll: Supported Go versions #225

Closed
GeertJohan opened this issue Feb 17, 2015 · 5 comments
Closed

Poll: Supported Go versions #225

GeertJohan opened this issue Feb 17, 2015 · 5 comments

Comments

@GeertJohan
Copy link
Member

What versions of Go do we want to support?

I would be in favor of the last 2 minor releases, right now that is: go1.3.x and go1.4.x. When go1.5 is released, we will support go1.4.x and go1.5.x.
Go has a great compatibility promise. Upgrading to a newer version of go is never really an issue, so most projects using gorp won't have trouble staying up-to-date.

Please comment.

Notify top contributors and new maintainers: @coopernurse @robfig @sqs @nelsam @sqdk @begizi @benprew

@sqdk
Copy link
Member

sqdk commented Feb 17, 2015

Sounds good to me!

@GeertJohan
Copy link
Member Author

Some backstory: this issue originates from #224, where @sqdk noticed that the go1.1 build fails because go-sql-driver/mysql uses a function introduced in go1.2.

@nelsam
Copy link
Member

nelsam commented Feb 17, 2015

I agree with supporting the latest two versions. Anything more than that is going to hit us with some pretty ugly limits in the future.

@GeertJohan
Copy link
Member Author

This poll has been open long enough. I suggest we go ahead with implementing these changes. I'll open a PR.

@GeertJohan
Copy link
Member Author

PR is #234 (which is a pretty nice number since it's introducing travis checks for go 1.2, 1.3 and 1.4 😄 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants